[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] travis.yml: Run tcg tests with tci
From: |
Alex Bennée |
Subject: |
Re: [PATCH] travis.yml: Run tcg tests with tci |
Date: |
Thu, 28 Nov 2019 10:16:20 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Thomas Huth <address@hidden> writes:
> On 27/11/2019 19.38, Alex Bennée wrote:
>> Thomas Huth <address@hidden> writes:
>>
>>> So far we only have compile coverage for tci. But since commit
>>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation
>>> for INDEX_op_ld16u_i64") has been included, we can also run the
>>> x86 TCG tests with tci, so let's enable them in Travis now.
>>>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>> .travis.yml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index c09b6a0014..b0b634d484 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -218,7 +218,7 @@ matrix:
>>> # We manually include builds which we disable "make check" for
>> this comment is out of date now (or rather has been for a while)
>>
>>> - env:
>>> - CONFIG="--enable-debug --enable-tcg-interpreter"
>> Perhaps as linux-user doesn't add much to testing the TCG we could
>> limit
>> by MAIN_SOFTMMU_TARGETS here?
>
> Limiting is a good idea, but I think we should use the architectures
> that are supported by tests/boot-serial-test.c instead.
Maybe a new env - TESTBOOT_SOFTMMU_TARGETS?
>
>>> - - TEST_CMD=""
>>> + - TEST_CMD="make run-tcg-tests-x86_64-softmmu V=1"
>> How about "make check-qtest check-tcg"
>> > Which will exercise the moderate boot code tests of various
>> architectures as well as x86_64 (if we include the --disable-docker
>> configure stanza)
>
> I tried "check-tcg" before switching to
> "run-tcg-tests-x86_64-softmmu", but "check-tcg" then resulted in a
> docker error:
>
> https://travis-ci.com/huth/qemu/jobs/260949876#L11974
>
> ... so looks like we indeed have to use --disable-docker in that case.
>
> I'll have a try and send a v2 if that works out fine.
>
> Thomas
--
Alex Bennée