Re: [PATCH-for-4.2 v3 1/3] hw/block/pflash: Remove dynamic field width from trace events

[Philippe Mathieu-Daudé]

On 11/18/19 10:15 PM, Eric Blake wrote:
> On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote:
> > Since not all trace backends support dynamic field width in
> > format (dtrace via stap does not), replace by a static field
> > width instead.
> >
> > We previously passed to the trace API 'width << 1' as the number
> > of hex characters to display (the dynamic field width). We don't
> > need this anymore. Instead, display the size of bytes accessed.
> >
> > Reported-by: Eric Blake <address@hidden>
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> Is it worth a Fixes: XXX calling out the commit that introduced the '*'?

Yes, good idea.

> /me goes and searches
>
> Fixes: e8aa2d95ea
> Fixes: c1474acd5d

Similarly the next patch (hw/mips/gt64xxx_pci.c) fixes ab6bff424f4.

> Reviewed-by: Eric Blake <address@hidden>

Thanks!