[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] event_notifier: avoid dandling file descriptor in event_
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 2/3] event_notifier: avoid dandling file descriptor in event_notifier_cleanup |
Date: |
Thu, 24 Oct 2019 19:27:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit :
> If rfd is equal to wfd the file descriptor is closed but
> rfd will still have the closed value.
> The EventNotifier structure should not be used again after calling
> event_notifier_cleanup or should be initialized again but make
> sure to not have dandling file descriptors around.
>
> Signed-off-by: Frediano Ziglio <address@hidden>
> ---
> util/event_notifier-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c
> index 73c4046b58..00d93204f9 100644
> --- a/util/event_notifier-posix.c
> +++ b/util/event_notifier-posix.c
> @@ -80,8 +80,8 @@ void event_notifier_cleanup(EventNotifier *e)
> {
> if (e->rfd != e->wfd) {
> close(e->rfd);
> - e->rfd = -1;
> }
> + e->rfd = -1;
> close(e->wfd);
> e->wfd = -1;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[PATCH 2/3] event_notifier: avoid dandling file descriptor in event_notifier_cleanup, Frediano Ziglio, 2019/10/23
Re: [PATCH 1/3] util/async: avoid useless cast, Laurent Vivier, 2019/10/23
Re: [PATCH 1/3] util/async: avoid useless cast, Laurent Vivier, 2019/10/24