qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu-options.hx: Update for reboot-timeout parameter


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] qemu-options.hx: Update for reboot-timeout parameter
Date: Tue, 22 Oct 2019 14:52:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 10/22/19 8:18 AM, Markus Armbruster wrote:
Han Han <address@hidden> writes:

Since ee5d0f89d, -1 is not valid for the value of reboot-timeout. Update
that in qemu-options doc.

Signed-off-by: Han Han <address@hidden>
---
  qemu-options.hx | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 793d70ff..6b92a916 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by 
the SVGA mode, so
    A splash picture could be passed to bios, enabling user to show it as logo,
    when option splash=@var{sp_name} is given and menu=on, If firmware/BIOS
    supports them. Currently Seabios for X86 system support it.
    limitation: The splash file could be a jpeg file or a BMP file in 24 BPP
    format(true color). The resolution should be supported by the SVGA mode, so
  the recommended is 320x240, 640x480, 800x640.
A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
-reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
+when boot failed, then reboot. If @option{reboot-timeout} is not set,
+guest will not reboot by default. Currently Seabios for X86
  system support it.
Do strict boot via @option{strict=on} as far as firmware/BIOS

Preexisting: "could be passed" sounds awkward.  Same in the previous
paragraph.  Not this patch's problem, so:

Reviewed-by: Markus Armbruster <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

I assume this patch will go via qemu-trivial.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]