[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] qemu-iotests: remove forceful execution success from lib

From: Eric Blake
Subject: Re: [PATCH 2/4] qemu-iotests: remove forceful execution success from library files
Date: Fri, 27 Sep 2019 11:47:02 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 9/27/19 9:17 AM, Cleber Rosa wrote:
Should not be necessary on files that are not executed standalone.

Signed-off-by: Cleber Rosa <address@hidden>
  tests/qemu-iotests/common.config | 3 ---
  tests/qemu-iotests/common.filter | 3 ---
  tests/qemu-iotests/common.rc     | 3 ---
  3 files changed, 9 deletions(-)

diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
index 6956d38d4c..0a24d960ff 100644
--- a/tests/qemu-iotests/common.config
+++ b/tests/qemu-iotests/common.config
@@ -34,6 +34,3 @@ _optstr_add()
          echo "$2"
-# make sure this script returns success

The exit status of the source command in the caller depends on the last command executed here.

However, you also have the point that if you delete this line, the last command executed is a function definition which is successful (for all 3 files touched). So there is no behavior change in dropping this line.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]