[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Disallow colons in the parameter of "-accel"

From: Peter Maydell
Subject: Re: [PATCH] Disallow colons in the parameter of "-accel"
Date: Mon, 23 Sep 2019 13:46:47 +0100

On Mon, 23 Sep 2019 at 13:42, Thomas Huth <address@hidden> wrote:
> On 23/09/2019 14.23, Peter Maydell wrote:
> > This seems pretty ugly.
> Yes. The whole "-accel" option is currently ugly. My patch is just a
> temporary work-around to prevent that we later have to deal with the
> fact that users started to use this colon here in the wild and we would
> then have to fight to get rid of it again.
> > If -accel is the way we're recommending
> > users configure the accelerator then it should support syntax
> > for specifying everything we could do with the old -machine...
> > option.
> No, we certainly don't want to have the colon in here. The idea is
> rather that you could specify multiply "-accel" options one day, e.g.:
>  -accel tcg,tb-size=2048 -accel kvm,kernel_irqchip=on
> ... and then the accelators are used with the right parameters in the
> order of availability.
> Per-accelerator parameters just don't work here if you allow the colon.
> (IMHO we should not have let the -accel code enter the repository in
> this shape, but rather insist on a proper implementation right from the
> start - but now that it's there, we have to deal with it and should make
> sure that it does not get worse)

Ah, I hadn't realised that -accel was a (relatively) long-standing
option; I'd just noticed some patches going past recently suggesting
we were starting to recommend it over -machine accel=.
Thanks for trying to clean it up a bit.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]