[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] hw/misc: Mark most objects as "common" code t

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] hw/misc: Mark most objects as "common" code to speed up compilation a litte bit
Date: Thu, 5 Sep 2019 09:24:04 +0100
User-agent: Mutt/1.12.1 (2019-06-15)

On Mon, Sep 02, 2019 at 06:26:38PM +0200, Thomas Huth wrote:
> Most of the code in hw/misc/ does not directly depend on CPU-specific
> code. Mark it as "common" so that the code can be shared between e.g.
> qemu-system-arm and qemu-system-aarch64, or between the various mips
> flavours, instead of recompiling it for each and every target again
> and again.
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  hw/misc/Makefile.objs | 90 +++++++++++++++++++++----------------------
>  1 file changed, 45 insertions(+), 45 deletions(-)

Nice.  My understanding is that we poison symbols so target-specific
code accidentally added to common-obj-y should fail to compile.
Therefore I didn't audit the affected code to see if it has
target-specific dependencies.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]