Re: [Qemu-trivial] [Qemu-devel] [PATCH] audio: Add missing fall through comments

[Aleksandar Markovic]

On Jul 19, 2019 9:30 AM, "Philippe Mathieu-Daudé" <address@hidden> wrote:
>
> On 7/18/19 9:34 PM, Stefan Weil wrote:
> > Signed-off-by: Stefan Weil <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>

Philippe, how do you test these comments?

Yours, Aleksandar

> > ---
> >  audio/audio.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/audio/audio.c b/audio/audio.c
> > index 5fd9a58a80..a7a13e900a 100644
> > --- a/audio/audio.c
> > +++ b/audio/audio.c
> > @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
> > 
> >      case AUDIO_FORMAT_S16:
> >          sign = 1;
> > +        /* fall through */
> >      case AUDIO_FORMAT_U16:
> >          bits = 16;
> >          shift = 1;
> > @@ -311,6 +312,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
> > 
> >      case AUDIO_FORMAT_S32:
> >          sign = 1;
> > +        /* fall through */
> >      case AUDIO_FORMAT_U32:
> >          bits = 32;
> >          shift = 2;
> >
>