[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 2/2] configure: disallow spaces and colons
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [PATCH v3 2/2] configure: disallow spaces and colons in source path and build path |
Date: |
Wed, 26 Jun 2019 17:56:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Le 26/05/2019 à 16:47, Antonio Ospite a écrit :
> From: Antonio Ospite <address@hidden>
>
> The configure script breaks when the qemu source directory is in a path
> containing white spaces, in particular the list of targets is not
> correctly generated when calling "./configure --help" because of how the
> default_target_list variable is built.
>
> In addition to that, *building* qemu from a directory with spaces breaks
> some assumptions in the Makefiles, even if the original source path does
> not contain spaces like in the case of an out-of-tree build, or when
> symlinks are involved.
>
> To avoid these issues, refuse to run the configure script and the
> Makefile if there are spaces or colons in the source path or the build
> path, taking as inspiration what the kbuild system in linux does.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1817345
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Antonio Ospite <address@hidden>
> ---
> Makefile | 4 ++++
> configure | 5 +++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index e02b88bcb1..bed1323a45 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,5 +1,9 @@
> # Makefile for QEMU.
>
> +ifneq ($(words $(subst :, ,$(CURDIR))), 1)
> + $(error main directory cannot contain spaces nor colons)
> +endif
> +
> # Always point to the root of the build tree (needs GNU make).
> BUILD_DIR=$(CURDIR)
>
> diff --git a/configure b/configure
> index 9f12120ad9..2833d73ccc 100755
> --- a/configure
> +++ b/configure
> @@ -279,6 +279,11 @@ ld_has() {
> # make source path absolute
> source_path=$(cd "$(dirname -- "$0")"; pwd)
>
> +if printf %s\\n "$source_path" "$PWD" | grep -q "[[:space:]:]";
> +then
> + error_exit "main directory cannot contain spaces nor colons"
> +fi
> +
> # default parameters
> cpu=""
> iasl="iasl"
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [PATCH v3 2/2] configure: disallow spaces and colons in source path and build path,
Laurent Vivier <=