[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrando
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity |
|
Date: |
Fri, 31 May 2019 11:44:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/30/19 7:38 PM, Richard Henderson wrote:
> Explicitly ignore the return value of qemu_guest_getrandom.
> Because we use error_fatal, all errors are already caught.
>
> Fixes: CID 1401701
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> util/guest-random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/guest-random.c b/util/guest-random.c
> index e8124a3cad..00a08fd981 100644
> --- a/util/guest-random.c
> +++ b/util/guest-random.c
> @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error
> **errp)
>
> void qemu_guest_getrandom_nofail(void *buf, size_t len)
> {
> - qemu_guest_getrandom(buf, len, &error_fatal);
> + (void)qemu_guest_getrandom(buf, len, &error_fatal);
> }
>
> uint64_t qemu_guest_random_seed_thread_part1(void)
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>