[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefi
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message |
Date: |
Wed, 15 May 2019 14:33:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Stefano Garzarella <address@hidden> writes:
> Reword and add a missing parentheses at the end of the
> error message.
>
> Signed-off-by: Stefano Garzarella <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> v2:
> - Reworded the error message (Markus)
> - Added Marc-André's R-b
> I made a little change to the error message, let me now
> if I should remove yuor R-b.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 95934fb36d..b34cb29276 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const
> char *model,
> }
> if (vprefix6_len < 0 || vprefix6_len > 126) {
> error_setg(errp,
> - "Invalid prefix provided (prefix len must be in range
> 0-126");
> + "Invalid IPv6 prefix provided "
> + "(IPv6 prefix length must be between 0 and 126)");
> return -1;
> }
"Parameter 'ipv6-prefixlen' expects a value between 0 and 126" would be
closer to how we report similar errors elsewhere.
Regardless:
Reviewed-by: Markus Armbruster <address@hidden>