[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/timer: Compile devices not target-dependen
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [PATCH] hw/timer: Compile devices not target-dependent as common objects |
|
Date: |
Wed, 8 May 2019 14:29:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 06/05/19 03:06, Philippe Mathieu-Daudé wrote:
>> By the way, I was surprised to see TARGET_FMT_plx there, since I first
>> thought that this would be a target-specific define, too. But apparently
>> it is not. Very confusing. I'd suggest to rename that to HWADDR_FMT_plx
>> instead, what do you think?
> I'd rather use HWADDR_PRIx and slowly kill TARGET_FMT_plx...
Right, either that or rename it to HWADDR_PRI0x.
Paolo