[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH v3 1/2] hw/arm/virt: Remove null-check in virt_bui

From: Philippe Mathieu-Daudé
Subject: [Qemu-trivial] [PATCH v3 1/2] hw/arm/virt: Remove null-check in virt_build_smbios()
Date: Sat, 9 Mar 2019 19:19:19 +0100

Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board",
2014-12-22), the machvirt_init() unconditionally creates the
fw_cfg object.  Later, commit c30e15658b1b ("smbios: implement
smbios support for mach-virt", 2015-09-07) added a superfluous
null-check on it.
Remove this superfluous check.

Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
v2: Corrected commit reference (Laszlo)
v3: Dropped 'Fixes:' (Markus)
 hw/arm/virt.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 7f66ddad89..377e95a4cd 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1281,10 +1281,6 @@ static void virt_build_smbios(VirtMachineState *vms)
     size_t smbios_tables_len, smbios_anchor_len;
     const char *product = "QEMU Virtual Machine";
-    if (!vms->fw_cfg) {
-        return;
-    }
     if (kvm_enabled()) {
         product = "KVM Virtual Machine";

reply via email to

[Prev in Thread] Current Thread [Next in Thread]