[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_
Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
Tue, 17 Jul 2018 12:36:06 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
On 16/07/2018 20:47, Daniel P. Berrange wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
>> The value argument can be NULL, for example, in hw/i386/multiboot.c
>> in the load_multiboot function get_opt_value is explicitly called
>> with NULL as the second argument.
>> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
>> silently truncate long option values"). This change fixes the
>> problem by adding a check whether the value is NULL or not.
>> Signed-off-by: Mike Krinkin <address@hidden>
>> util/qemu-option.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> This problem is fixed in this:
> but it is still waiting for i386 maintainers to respond....
Generally Kevin has looked at multiboot patches, but I'll merge these
ones because he's on vacation. Thanks,