[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 08/10] ui: document non-qapi parser cases.
From: |
Gerd Hoffmann |
Subject: |
[Qemu-trivial] [PULL 08/10] ui: document non-qapi parser cases. |
Date: |
Tue, 15 May 2018 11:18:59 +0200 |
Add comments to the cases not (yet) switched
over to parse_display_qapi().
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
---
vl.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/vl.c b/vl.c
index 5f1734d851..3b39bbd7a8 100644
--- a/vl.c
+++ b/vl.c
@@ -2114,6 +2114,16 @@ static void parse_display(const char *p)
const char *opts;
if (strstart(p, "sdl", &opts)) {
+ /*
+ * sdl DisplayType needs hand-crafted parser instead of
+ * parse_display_qapi() due to some options not in
+ * DisplayOptions, specifically:
+ * - frame
+ * Already deprecated.
+ * - ctrl_grab + alt_grab
+ * Not clear yet what happens to them long-term. Should
+ * replaced by something better or deprecated and dropped.
+ */
dpy.type = DISPLAY_TYPE_SDL;
while (*opts) {
const char *nextopt;
@@ -2179,6 +2189,10 @@ static void parse_display(const char *p)
opts = nextopt;
}
} else if (strstart(p, "vnc", &opts)) {
+ /*
+ * vnc isn't a (local) DisplayType but a protocol for remote
+ * display access.
+ */
if (*opts == '=') {
vnc_parse(opts + 1, &error_fatal);
} else {
--
2.9.3
- [Qemu-trivial] [PULL 00/10] Ui 20180515 patches, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 01/10] sdl2: move opts assignment into loop, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 08/10] ui: document non-qapi parser cases.,
Gerd Hoffmann <=
- [Qemu-trivial] [PULL 05/10] ui: add qapi parser for -display, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 10/10] gtk: disable the F10 menubar key, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 04/10] vnc: add magic cookie to VncState, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 03/10] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 02/10] gtk: make it possible to hide the menu bar, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 06/10] ui: switch trivial displays to qapi parser, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 09/10] console: use linked list for QemuConsoles, Gerd Hoffmann, 2018/05/15
- [Qemu-trivial] [PULL 07/10] ui: switch gtk display to qapi parser, Gerd Hoffmann, 2018/05/15
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/10] Ui 20180515 patches, Peter Maydell, 2018/05/15