[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-pr-helper: Actually allow u

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile
Date: Sat, 24 Mar 2018 06:44:28 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/24/2018 12:14 AM, Michal Privoznik wrote:
Due to wrong specification of arguments to getopt_long() any
attempt to set pidfile resulted in:

1) the default to be leaked
2) the @pidfile variable to be set to NULL (because optarg is
NULL without this patch).

Broken in introduction with commit b855f8d, in 2.11.

Signed-off-by: Michal Privoznik <address@hidden>

CC: address@hidden
Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]