[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 0/4] coccinelle: re-run scripts from scripts/c

From: Eric Blake
Subject: Re: [Qemu-trivial] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle
Date: Fri, 23 Mar 2018 12:42:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/23/2018 07:37 AM, Michael Tokarev wrote:
22.03.2018 19:12, Laurent Vivier wrote:
I've re-run some scripts from the coccinelle directory,
and they have found some problems.

This series fixes them.

Laurent Vivier (4):
   error: Strip trailing '\n' from error string arguments (again again)
   error: Remove NULL checks on error_propagate() calls
   qdict: remove useless cast
   Remove unnecessary variables for function return value

I've applied patches 1-3, but the 4th patch is a bit.. interesting.
As has already been said, it touches auto-generated files, which is
sort of fine, but it _also_ removes comments, which - I think - is
quite a bit wrong.

1-3 are also candidates for going through my qapi tree (I will probably do another pull request Monday or Tuesday), if that beats your trivial tree. But if not, for 1-3, you can add:
Acked-by: Eric Blake <address@hidden>

I can apply just selected hunks, but.. hmm..

v2 of patch 4 is better, and the trivial tree may indeed be a better place for patch 4 since it doesn't really touch anything qapi-related.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]