[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 0/4] coccinelle: re-run scripts from scripts/c

From: Eric Blake
Subject: Re: [Qemu-trivial] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle
Date: Thu, 22 Mar 2018 11:27:52 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/22/2018 11:12 AM, Laurent Vivier wrote:
I've re-run some scripts from the coccinelle directory,
and they have found some problems.

This series fixes them.

Laurent Vivier (4):
   error: Strip trailing '\n' from error string arguments (again again)

This is user-visible, so appropriate during freeze as a bug fix. It's closes to the error/qapi code that Markus normally maintains (and where I'm filling in while he is out), so I'll queue this one on my QAPI tree.

   error: Remove NULL checks on error_propagate() calls
   qdict: remove useless cast
   Remove unnecessary variables for function return value

These are cosmetic; they should be no-ops. 2 and 3 are again best through error/qapi, while 4 is more generic, but there's little reason to split up the series just because 4 is not as closely related. Unless anyone has an opinion otherwise, I'm planning to also include them in my QAPI tree for 2.12.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]