[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 0/3] hw/rdma: Fix 32-bit compilation

From: Eric Blake
Subject: Re: [Qemu-trivial] [PATCH 0/3] hw/rdma: Fix 32-bit compilation
Date: Wed, 21 Mar 2018 17:24:52 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/21/2018 04:10 PM, Yuval Shaia wrote:
Hi all,
Following are three patches which fixes various compilation warnings and
errors detected when compiling rdma device in 32bit host.

All three patches are based on Eric Blake patch for rdma device.

Patch #1: Change host_virt to void *
Low level IB verbs library accept void * argument so let's make sure this
is what we supply. This issue reported by Eric Blake.

Patch #2: Use correct print format in CHK_ATTR macro
This macro can utilize the given 'format' argument and not need to cast all
members to u64. This patch is an alternative to suggested patch by Eric

Patch #3: Fix 32-bit compilation
Based on Eric Blake patch this patch replaces all %ld/%lx with the platform
independent PRIx64/PRId64 format.

Again, thanks Eric Blake for the report.

Yuval Shaia (3):
   hw/rdma: Change host_virt to void *
   hw/rdma: Use correct print format in CHK_ATTR macro

Your fix was nicer than my proposal.

   hw/rdma: Fix 32-bit compilation

Reviewed-by: Eric Blake <address@hidden>

and it fixes the build on my 32-bit rawhide VM, so

Tested-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]