[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/c
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" |
|
Date: |
Mon, 5 Mar 2018 18:57:54 +0000 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote:
> These files were including "qemu/cutils.h" to use the byte-based size
> definitions, now available in "qemu/cunits.h".
I know I'm "complaining" about bike-shed colour here....
Feels like just calling it units.h is sufficient - all our .h code is
C code so don't need reminding of it by filename, particularly since
we're avoiding system header clash by using the qemu/ prefix on #includes.
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Regardless of whether you rename it or not though,
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-trivial] [PATCH v2 00/30] hw: use the BYTE-based definitions when useful, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h", Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/03/05
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h",
Daniel P . Berrangé <=
- [Qemu-trivial] [PATCH v2 04/30] hw/lm32/milkymist: remove unused include, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 05/30] hw/mips/r4k: constify params_size, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 06/30] hw/mips: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 07/30] hw/arm: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 08/30] hw/i386: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 09/30] hw/sparc: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05