|Subject:||Re: [Qemu-trivial] [PATCH 1/1] tci: eliminate UB due to unaligned reads|
|Date:||Sat, 3 Mar 2018 17:07:37 +0300|
On 03/03/2018 12:54 AM, Anatoly Trosinenko wrote:
> Patchwork link: http://patchwork.ozlabs.org/
> Patchew link:
> The code in tcg/tci.c reads some data from TCI bytecode through
> pointer dereferencing. As far as I know unaligned reads in such a way are
> undefined behavior and compiling with -fsanitize=undefined enumerated
> them as such at run-time.
This is exactly one of the reasons why I have urged for TCI to be abandoned.
While your patch works, it is *enormously* inefficient for hosts that require it.
|[Prev in Thread]||Current Thread||[Next in Thread]|