[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 30/39] hw/display/vga: remove the old i386/
From: |
Thomas Huth |
Subject: |
Re: [Qemu-trivial] [PATCH v2 30/39] hw/display/vga: remove the old i386/pc dependency |
Date: |
Tue, 17 Oct 2017 13:09:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 17.10.2017 12:49, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
>>> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
>>> index ad34a1f048..fe23b81442 100644
>>> --- a/hw/display/vga_int.h
>>> +++ b/hw/display/vga_int.h
>>> @@ -25,8 +25,9 @@
>>> #ifndef HW_VGA_INT_H
>>> #define HW_VGA_INT_H
>>>
>>> -#include "hw/hw.h"
>>> +#include "exec/ioport.h"
>>> #include "exec/memory.h"
>>> +#include "ui/console.h"
>>
>> So vga_int.h now includes console.h (is it really necessary?) ...
>
> The VGACommonState struct has a GraphicHwOps *hw_ops member.
Ok, thanks, I just wanted to confirm that this is needed here.
[...]
> Do you suggest me do declare GraphicHwOps opaque in "qemu/typedefs.h"?
No, I think it's fine if you keep the #include in vga_int.h, I just
wanted to make sure that it is really needed there. So please just
remove the #includes from the .c files instead.
Thomas
- [Qemu-trivial] [PATCH v2 24/39] hw/i2c: remove old i386 dependency, (continued)
- [Qemu-trivial] [PATCH v2 24/39] hw/i2c: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 26/39] hw/virtio-balloon: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 25/39] hw/tpm: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 27/39] hw/unicore32: restrict hw addr defines to source file, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 28/39] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 29/39] hw/timer/i8254: rename pit_init() -> i8254_pit_init(), Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 30/39] hw/display/vga: remove the old i386/pc dependency, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 32/39] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init(), Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 31/39] hw/input/i8042: extract pckbd and vmmouse API from hw/i386/pc.h, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 34/39] misc: drop old i386 dependency, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 33/39] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 35/39] i386/pc: move vmport.c from hw/misc/ to hw/i386/, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-trivial] [PATCH v2 36/39] i386/pc: move pvpanic.c from hw/misc/ to hw/i386/, Philippe Mathieu-Daudé, 2017/10/16