[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.11] tests/bios-tables: Sile
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.11] tests/bios-tables: Silence some messages with V=1, print them with V=2 only
Thu, 31 Aug 2017 15:35:58 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
On 30.08.2017 15:48, Igor Mammedov wrote:
> On Mon, 28 Aug 2017 19:39:45 +0200
> Thomas Huth <address@hidden> wrote:
>> When running "make check-qtest-x86_64 V=1", the output is currently flooded
>> with "Looking for expected file ..." and "Using expected file ..." messages.
>> None of the other tests is doing that with V=1, so this is a little bit
>> annoying. Let's only print these debug messages when we're running the test
>> with V=2 or higher.
> well, normally make check is run without V=
> and if someone once in a while need to run it in verbose mode,
> he/she can tolerate it since it's a verbose mode after all.
> Hiding message behind V=XX is going to make us remember/recall
> at which verbosity level one needs to run tests to get needed
> diagnostic info.
> I'd rather keep it as it is now.
Well, I love to run the tests with V=1, especially as soon as one of the
tests hangs. But the output of the bios-tables-test really breaks the
well-formatted output of the test framework in that case, so adding a
V=2 debug level is IMHO a good idea. But if I'm the only who's annoyed
by the current output of the bios-tables-test, feel free to ignore me ;-)