|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-trivial] [PATCH for 2.10 03/35] thunk: check nb_fields is valid before continuing |
Date: | Wed, 26 Jul 2017 19:48:38 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/24/2017 03:37 PM, Eric Blake wrote:
On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote:thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes se->field_offsets[i] = malloc(nb_fields * sizeof(int)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <address@hidden> --- thunk.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Better would be fixing the code to use g_new0, and the corresponding free.
Ok, for 2.11 although (not a fix).Also thunk* alloc'd are never free'd during process lifetime, so will keep like that (no g_free).
[Prev in Thread] | Current Thread | [Next in Thread] |