[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in

From: Juan Quintela
Subject: Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h
Date: Wed, 28 Jun 2017 11:32:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> On 22 June 2017 at 19:08, Thomas Huth <address@hidden> wrote:
>>> On 22.06.2017 19:50, Dr. David Alan Gilbert wrote:
>>>> Could do; I'm just not finding tiny header files with one or
>>>> two entries each that useful.
>> Well, it means that the bulk of code that doesn't care about the
>> types doesn't get its compilation fractionally slowed by having
>> to parse the typedef anyway. In general I think we're drifting
>> towards "have each .c file get fewer things automatically" rather
>> than otherwise (eg more finely focused files rather than stuffing
>> everything into qemu-common.h).
> Yes.  See also "Our use of #include is undisciplined, and what to do
> about it"
> Message-ID: <address@hidden>
> https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03271.html
> I have some unfinished work towards emptying out qemu-common.h.  Need
> to find the time to finish it.
> [...]


Once there, we can also do other cleanups.


have things not related at all.
I want to get rid of it on migration, because you know, we do zero
emulation there, but there are things like "runstate" that are defined

I removed on that version lots of migration functionality that were
there, just from historical reasons, not because they belong there.

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]