[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include
Date: Fri, 9 Jun 2017 18:28:56 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 05/23/2017 11:58 AM, Michael Tokarev wrote:
09.05.2017 02:39, Philippe Mathieu-Daudé wrote:
"exec/memory.h" already includes it.

I think this sort of include cleanups isn't really necessary.

Some are useful ;)

For a regular include file, it's better to include it if the
.c file in question uses definitions from there, no matter if
other .h files include that header already or not.

Ok. This one was incorrect anyway :( thank for the review!



Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
 include/hw/arm/arm.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h
index a3f79d3379..b9c11d3fb8 100644
--- a/include/hw/arm/arm.h
+++ b/include/hw/arm/arm.h
@@ -14,7 +14,6 @@
 #include "exec/memory.h"
 #include "target/arm/cpu-qom.h"
 #include "hw/irq.h"
-#include "qemu/notify.h"

 typedef enum {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]