Re: [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile

[Philippe Mathieu-Daudé]

On 05/30/2017 12:04 PM, Greg Kurz wrote:
> The address@hidden target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> Signed-off-by: Greg Kurz <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  pc-bios/s390-ccw/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..7af57dad109c 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
>         $(call quiet-command,$(CC) $(LDFLAGS) -o $@ 
> $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
>  s390-ccw.img: s390-ccw.elf
> -       $(call quiet-command,strip --strip-unneeded $< -o 
> $@,"STRIP","$(TARGET_DIR)$@")
> +       $(call quiet-command,$(STRIP) --strip-unneeded $< -o 
> $@,"STRIP","$(TARGET_DIR)$@")
>
>  $(OBJECTS): Makefile