[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] syscall: fix compiler warnings (

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)
Date: Wed, 10 May 2017 14:41:23 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

>> The "for" loop scans the structure to find the rt_dev field, and we
>> should always enter in the first "if", so "host_rt_dev_ptr" is always
>> set.
> It's better indeed, I'll use g_assert_nonnull() and resend.

Careful - we haven't yet resolved whether g_assert_nonnull() is safe to use.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]