[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] jazz_led: fix bad snprintf
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] jazz_led: fix bad snprintf |
|
Date: |
Wed, 3 May 2017 15:10:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/05/2017 14:56, Markus Armbruster wrote:
>> snprintf writes at most 2 bytes here including the terminating NUL, so
>> the result is truncated".
>
> You're right; I forgot that snprintf() always adds a NUL. So this *is*
> broken: we write NUL instead of the second digit. Mentioning this in
> the commit message wouldn't hurt.
Well, it does, see the quote. :)
Paolo
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05