[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH for-2.9? v4] ipmi: Fix macro issues

From: Ed Maste
Subject: Re: [Qemu-trivial] [PATCH for-2.9? v4] ipmi: Fix macro issues
Date: Fri, 31 Mar 2017 13:49:23 -0400

On 31 March 2017 at 11:04, Eric Blake <address@hidden> wrote:
> Might also be worth adding that an audit of the code finds no semantic
> change, that this is just cleaning up the compiler warning.

We should include core detail of your detailed analysis in such a
statement I think, because I it's more than just cleaning up a
warning. For me at least the warning pointed out that the expression
is not parsed would be expected (if this were a function and not a
macro), and it's just because of constraints on the inputs that
there's no functional change.

>> Signed-off-by: Corey Minyard <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Ed Maste <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]