[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Make 'replication_state'

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Make 'replication_state' an enum
Date: Tue, 21 Mar 2017 12:52:22 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/16/2017 09:17 PM, Fam Zheng wrote:
> BDRVReplicationState.replication_state is a name with a bit of
> duplication, plus it could be an enum like BDRVReplicationState.mode,
> which is be more readable and also more straightforward in a debuuger.

With the followup commit message cleanups,

Reviewed-by: Eric Blake <address@hidden>

> Rename it, and improve the type while at it.
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  block/replication.c | 44 ++++++++++++++++++++++----------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]