[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] checkpatch: Supress warning in f

From: Vinzenz Feenstra
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs
Date: Tue, 21 Mar 2017 14:01:09 +0100

> On Mar 21, 2017, at 1:37 PM, Peter Maydell <address@hidden> wrote:
> On 16 March 2017 at 11:14, Vinzenz 'evilissimo' Feenstra
> <address@hidden> wrote:
>> From: Vinzenz Feenstra <address@hidden>
>> When importing dynamically functions via `GetProcAddress` in windows
>> related code, it is quite common to make a typedef for the resulting
>> function pointer. When the function to be imported, has a stdcall
>> calling convention, usually the `WINAPI` macro is used. This patch adds an
>> exception in the checkpatch.pl script to allow the calling convention
>> specification in function pointer typedefs, to be `WINAPI`.
>> Signed-off-by: Vinzenz Feenstra <address@hidden>
> Could you provide an example of the kind of source line that provokes
> the incorrect warning and the checkpatch output that results,
> please?

Hmm I just realize that it is working now, but I figured out now what is the 
real problem and that
my patch is wrong. Please discard this patch and thanks for making me think 
again :-)

> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]