[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] checkpatch: Supress warning in function pointer t

From: Vinzenz 'evilissimo' Feenstra
Subject: [Qemu-trivial] [PATCH] checkpatch: Supress warning in function pointer typedefs
Date: Thu, 16 Mar 2017 12:14:16 +0100

From: Vinzenz Feenstra <address@hidden>

When importing dynamically functions via `GetProcAddress` in windows
related code, it is quite common to make a typedef for the resulting
function pointer. When the function to be imported, has a stdcall
calling convention, usually the `WINAPI` macro is used. This patch adds an
exception in the checkpatch.pl script to allow the calling convention
specification in function pointer typedefs, to be `WINAPI`.

Signed-off-by: Vinzenz Feenstra <address@hidden>
 scripts/checkpatch.pl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f084542..33bf585 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1774,7 +1774,14 @@ sub process {
                        # likely a typedef for a function.
                        } elsif ($ctx =~ /$Type$/) {
-                       } else {
+            # If this is a typedef we need to allow WINAPI as a calling
+            # convention. Even though there should be only one space around the
+            # star, we allow none or any, to suppress the following warning.
+            # The check for the number of spaces around the star is checked
+            # elsewhere.
+                       } elsif($ctx =~ 
/^\s*typedef\s+$Type\(WINAPI\s*\*\s*$Ident\)/) {
+            } else {
                                ERROR("space prohibited between function name 
and open parenthesis '('\n" . $herecurr);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]