[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device i

From: BALATON Zoltan
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets
Date: Mon, 6 Mar 2017 19:34:40 +0100 (CET)
User-agent: Alpine 2.20 (BSF 67 2015-01-07)

On Mon, 6 Mar 2017, Peter Maydell wrote:
On 6 March 2017 at 09:52, Thomas Huth <address@hidden> wrote:
I guess we could do something like that on ppc, too (and ppc-softmmu.mak
should likely include ppcemb-softmmu.mak), but
that's something for QEMU 2.10 / 3.0 / whichever version will be next.

Yeah, definitely 2.10 material (so is this whole series, but
let's not tangle it up with an unrelated cleanup).

Thanks for all the comments investigations and reviews, which were really helpful. I'll test your suggestions and send another version if found to be needed but I don't have access to real hardware to test on, so I can't confirm this other than using images that are known to work on real hardware and I only have those for PPC. So I cannot test LE guest more than using the Linux images available on the net but can't guarantee those are not buggy. The current version (however unlikely) does work for both the more or less known good PPC images and the SH images I could find so this is the most likely correct combination given the test cases. I'm fairly sure the big endian case is correct and the SH LE case works better with the images available so unless there's another image that is known to work on SH, this is the best I could do.

If there is no chance to get this in for 2.9 (considering it changes a relatively unmaintained and unused part, so the risk of breaking something important is very low) then let's get back to this about a month from now because no point to spend time on it if it just gets forgotten until the next chance to get it merged. Unless you can take it during the freeze I'll pick this up later when the window opens again. (By the way, the planning link on the wiki still points to 2.8.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]