[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 10/14] sm501: Add support for

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer
Date: Thu, 2 Mar 2017 20:46:10 +0000

On 2 March 2017 at 20:15, BALATON Zoltan <address@hidden> wrote:
> On Thu, 2 Mar 2017, Peter Maydell wrote:
>> This is another refactoring that's unrelated to adding panel
>> layer support, right? (It's just changing from having src and
>> offset updated at the end of the loop to dropping src and having offset
>> be updated in the for()).
> It's a clean up getting rid of the unneded src pointer. Should I move it to
> the cleanup patch or is it OK to leave it here?

I've reviewed it now, so you can leave it. It would have
been better in its own patch, though. (The general principle
is that each patch should do only one thing, and it should do
all of that one thing, and the one thing should be fairly
small and easy to understand.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]