[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] Fix build break during configuration on

From: Chad Joan
Subject: Re: [Qemu-trivial] [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.
Date: Sun, 19 Feb 2017 02:22:41 -0500

This is kinda depressing to read :(

But thanks for explaining.

I got a good laugh when it mentioned of Lotus Notes, "Run away from it."

Would it be reasonable to stick a link to that article in the submit a patch document?  Something like, "If you can't use 'git send-email' for any reason, then please review [link]this article[/link] to understand which clients are capable of sending acceptable patches and how to configure them."

I suspect I'm going to encounter this problem again as I try to make small fixes for more projects, so it might be worth it for me to spend a small amount of time at some point setting up a mail client that I can send git patches with.  Or perhaps I can just move the patch(es) onto another machine (ex: my personal laptop) and send it with 'git send-email' from there, instead of needing to install a mail client that is outside of my normal workflow.  I am not comfortable with putting smtp login information onto the server that I am using for this work.  If anyone has any advice on how to handle this situation, I'd appreciate it.  That kernel doc that Peter linked is already pretty helpful, at least.


On Fri, Feb 17, 2017 at 12:15 PM, Peter Maydell <address@hidden> wrote:
On 17 February 2017 at 16:54, Chad Joan <address@hidden> wrote:
> so if we can test and
> approve even /some/ of the more popular mail clients (ex: gmail,
> thunderbird, outlook, etc) for use, it would help newbies A LOT.

Pretty sure we've seen mangled emails from all of those.
The problem is that most email clients will automatically
wrap long lines, which is fine for text but breaks an
inline patch. Changing trailing whitespace in patches is
also a common issue.

The documentation in "git help format-patch" has a section
"MUA-SPECIFIC HINTS" which says that gmail's web interface
is definitely no good, and Thunderbird defaults to the wrong
thing and requires a bunch of config changes which you'd then
have to switch back to your preferences for normal mail when
you're done sending patches. Outlook is so hopeless for
patch mail it isn't even listed :-)

The kernel docs have a longer list of mail clients with
notes about suitability:
but the set of "just works" clients is very small.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]