|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH] softfloat: Use correct type in float64_to_uint64_round_to_zero() |
Date: | Thu, 9 Feb 2017 19:15:29 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 02/03/2017 03:59 PM, Peter Maydell wrote:
In float64_to_uint64_round_to_zero() a typo meant that we were taking the uint64_t return value from float64_to_uint64() and putting it into an int64_t variable before returning it as uint64_t again. Use uint64_t instead of pointlessly casting it back and forth to int64_t. Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
--- Spotted while reading the code... fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index c295f31..218b375 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -7386,7 +7386,7 @@ uint64_t float64_to_uint64_round_to_zero(float64 a, float_status *status) { signed char current_rounding_mode = status->float_rounding_mode; set_float_rounding_mode(float_round_to_zero, status); - int64_t v = float64_to_uint64(a, status); + uint64_t v = float64_to_uint64(a, status); set_float_rounding_mode(current_rounding_mode, status); return v; }
[Prev in Thread] | Current Thread | [Next in Thread] |