[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 19/31] disas/cris.c: Fix Coverity warning about unc
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 19/31] disas/cris.c: Fix Coverity warning about unchecked NULL |
Date: |
Tue, 24 Jan 2017 12:39:23 +0300 |
From: Peter Maydell <address@hidden>
Coverity (CID 1005689) warns that we don't check that
spec_reg_info() returned non-NULL before dereferencing.
Add the check, though as the comment notes this is
a can't-really-happen case because the earlier constraint
matching should have ruled out the "unknown reg" case.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
disas/cris.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/cris.c b/disas/cris.c
index 08161d1..8a1daf9 100644
--- a/disas/cris.c
+++ b/disas/cris.c
@@ -2490,7 +2490,7 @@ print_with_operands (const struct cris_opcode *opcodep,
const struct cris_spec_reg *sregp
= spec_reg_info ((insn >> 12) & 15, disdata->distype);
- if (sregp->name == NULL)
+ if (sregp == NULL || sregp->name == NULL)
/* Should have been caught as a non-match earlier. */
*tp++ = '?';
else
--
2.1.4
- [Qemu-trivial] [PULL 15/31] qga: fix erroneous argument to strerror, (continued)
- [Qemu-trivial] [PULL 15/31] qga: fix erroneous argument to strerror, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 12/31] qemu-img: remove dead check, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 09/31] object.h: spelling fix, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 01/31] doc: don't mention -memory, it is -m, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 02/31] hw/block/m25p80: Fix typo in local macro name, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls(), Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 06/31] hw: Fix typos found by codespell, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 13/31] pci-assign: avoid pointless stat, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 28/31] gdbstub.c: fix GDB connection segfault caused by empty machines, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 31/31] hw/isa/isa-bus: Set category of the "isabus-bridge" device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 19/31] disas/cris.c: Fix Coverity warning about unchecked NULL,
Michael Tokarev <=
- [Qemu-trivial] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 03/31] README: Add linux to macOS build info, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 30/31] usb: Set category and description of the MTP device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 22/31] util/mmap-alloc: check parameter before using, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 16/31] doc/usb2: fix typo, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 21/31] vfio: remove a duplicated word in comments, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 05/31] include: Fix typos found by codespell, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 07/31] qemu-options: cleanup duplicated help message for kernel_irqchip, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 29/31] gdbstub.c: update old error report statements, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 27/31] scsi-disk: add 'fall through' comment to switch VERIFY cases, Michael Tokarev, 2017/01/24