[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix b

From: Adrian Bunk
Subject: Re: [Qemu-trivial] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default
Date: Mon, 28 Nov 2016 21:11:05 +0200
User-agent: NeoMutt/ (1.7.0)

On Mon, Nov 28, 2016 at 04:42:54PM +0100, Paolo Bonzini wrote:
> Aha, I looked at GCC source code and this is incorrect: "Use -r instead
> of -Wl,-r to avoid gcc passing -r to the linker when PIE is enabled".
> When GCC sees -r (as opposed to -Wl,-r) it does not pass -pie to the linker.

That's what I get for writing things I did not double-check myself...

You are correct here (with the implication that my patch does change
behaviour even less).

> Paolo



       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

reply via email to

[Prev in Thread] Current Thread [Next in Thread]