[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: fix missing assignmen

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay
Date: Tue, 1 Nov 2016 09:27:01 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 11/01/2016 12:50 AM, zhanghailiang wrote:
> We forgot to assign true to params->has_x_checkpoint_delay parameter
> in qmp_query_migrate_parameters.
> Without this, qmp command 'query-migrate-parameters' doesn't show the
> default value for x-checkpoint-delay option.
> It doesn't influence output of hmp command 'info migrate_parameters'.

Well, only because the current code doesn't forcefully assign missing
optional parameters to any other value.  But HMP was relying on
unspecified behavior, that could have broken with any other qapi change.

I might word the commit message:

This also fixes the fact that HMP was relying on unspecified behavior by
reading x_checkpoint_delay without checking has_x_checkpoint_delay.

Up to the maintainer, though, since the patch itself is fine.

> Signed-off-by: zhanghailiang <address@hidden>
> ---
>  hmp.c                 | 1 +
>  migration/migration.c | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]