Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.7] virtio-gpu: fix missing log.h include file

[Peter Maydell]

On 8 August 2016 at 10:31, Daniel P. Berrange <address@hidden> wrote:
> The virtio-gpu.h file defines a macro VIRTIO_GPU_FILL_CMD
> which includes a call to qemu_log_mask, but does not
> include qemu/log.h. In a default configure, it is lucky
> and gets qemu/log.h indirectly due to the 'log' trace
> backend being enabled. If that trace backend is disabled
> though, eg
>
>  ./configure --enable-trace-backends=nop
>
> Then the build will fail:
>
> In file included from 
> /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
> /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c: In function 
> ‘virgl_cmd_create_resource_2d’:
> /home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:13: error: 
> implicit declaration of function ‘qemu_log_mask’ 
> [-Werror=implicit-function-declaration]
>              qemu_log_mask(LOG_GUEST_ERROR,                              \
>              ^
> /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: note: in 
> expansion of macro ‘VIRTIO_GPU_FILL_CMD’
>      VIRTIO_GPU_FILL_CMD(c2d);
>      ^~~~~~~~~~~~~~~~~~~
> /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: error: nested 
> extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs]
> In file included from 
> /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
> /home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:27: error: 
> ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
>              qemu_log_mask(LOG_GUEST_ERROR,                              \
>
> [snip many more errors]
>
> Signed-off-by: Daniel P. Berrange <address@hidden>

Applied, thanks.

-- PMM