[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don'
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions |
Date: |
Tue, 28 Jun 2016 09:09:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/28/2016 08:50 AM, Peter Maydell wrote:
> Don't use the cpu_to_*w() functions, which we are trying to deprecate.
> Instead just use cpu_to_*() to do the byteswap, which brings the
> code in the marshal function in line with that in the unmarshal.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> fsdev/9p-iov-marshal.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> case 'q': {
> - uint64_t val;
> + uint64_t val = va_arg(ap, uint64_t);;
s/;;/;/
With that fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-trivial] [PATCH 0/6] Drop cpu_to_*w, *_to_cpup, document cpu_to_*, *_to_cpu, Peter Maydell, 2016/06/28
- [Qemu-trivial] [PATCH 5/6] bswap.h: Fix comment typo, Peter Maydell, 2016/06/28
- [Qemu-trivial] [PATCH 3/6] hw/bt: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/28
- [Qemu-trivial] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions, Peter Maydell, 2016/06/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions,
Eric Blake <=
- [Qemu-trivial] [PATCH 4/6] bswap.h: Remove unused cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/28
- [Qemu-trivial] [PATCH 6/6] bswap.h: Document cpu_to_* and *_to_cpu conversion functions, Peter Maydell, 2016/06/28
- [Qemu-trivial] [PATCH 2/6] block/qcow2: Don't use cpu_to_*w(), Peter Maydell, 2016/06/28