[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] gdbstub: avoid busy loop while waiting for
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [PATCH v2] gdbstub: avoid busy loop while waiting for gdb |
Date: |
Mon, 6 Jun 2016 12:04:35 +0100 |
On 5 June 2016 at 15:35, Peter Wu <address@hidden> wrote:
> While waiting for a gdb response, or while sending an acknowledgement
> there is not much to do, so do not mark the socket as non-blocking to
> avoid a busy loop while paused at gdb. This only affects the user-mode
> emulation (qemu-arm -g 1234 ./a.out).
>
> Note that this issue was reported before at
> https://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg02277.html.
>
> While at it, close the gdb client fd on EOF or error while reading.
>
> Signed-off-by: Peter Wu <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> ---
> v2: resent with fixed commit message + R-b from
> https://patchwork.kernel.org/patch/9008751/
Applied to master, thanks.
-- PMM