Re: [Qemu-trivial] [Qemu-devel] [PULL 00/52] Trivial patches for 2016-06-05

[Peter Maydell]

On 5 June 2016 at 08:42, Michael Tokarev <address@hidden> wrote:
> This is a big pile of patches collected in -trivial queue
> for quite a while.  I was busy with other stuff in recent
> months, now am trying to catch up.  This is the result,
> with everything all over.  Please consider pulling.
>
> /mjt
>
> The following changes since commit 6b3532b20b787cbd697a68b383232f5c3b39bd1e:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160603-1' into 
> staging (2016-06-03 12:03:36 +0100)
>
> are available in the git repository at:
>
>   git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2016-06-05
>
> for you to fetch changes up to 275757ac23428a641983200805bedee8f7b96793:
>
>   hbitmap: Use DIV_ROUND_UP (2016-06-05 10:10:48 +0300)
>
> ----------------------------------------------------------------
> trivial patches for 2016-06-05
>
> ----------------------------------------------------------------

Hi. I'm afraid this fails to configure on at least some platforms:

  GEN   qemu-options.def

ERROR: configure test passed without -Werror but failed with -Werror.
       This is probably a bug in the configure script. The failing command
       will be at the bottom of config.log.
       You can run configure with --disable-werror to bypass this check.

Tail end of config.log is:

cc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -fno-common -Wendif-labels
-Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -fstack-protector-all
-I/usr/include/p11-kit-1 -I/usr/include/libpng12
-I/usr/include/libusb-1.0 -o config-temp/qemu-conf.exe
config-temp/qemu-conf.c -g -nostdlib -Wl,-r -Wl,--no-relax
config-temp/qemu-conf.c:1:5: warning: no previous prototype for 'foo'
[-Wmissing-prototypes]
 int foo(void) { return 0; }
     ^
cc -Werror -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -fno-common -Wendif-labels
-Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -fstack-protector-all
-I/usr/include/p11-kit-1 -I/usr/include/libpng12
-I/usr/include/libusb-1.0 -o config-temp/qemu-conf.exe
config-temp/qemu-conf.c -g -nostdlib -Wl,-r -Wl,--no-relax
config-temp/qemu-conf.c:1:5: error: no previous prototype for 'foo'
[-Werror=missing-prototypes]
 int foo(void) { return 0; }
     ^

I think the problem commit is 'Fix linking relocatable objects on Sparc',
which adds a configure test that attempts to build an executable using
something that's not a valid C program (it has no 'main' function, for
instance, though that's not why the error here.)

thanks
-- PMM