Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

[Alex Williamson]

On Fri, 19 Feb 2016 15:18:10 +0000
Wei Yang <address@hidden> wrote:

> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is
> the more proper on retrieving MSIX entries.
> 
> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries.
> 
> Signed-off-by: Wei Yang <address@hidden>
> ---
>  hw/vfio/pci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index e66c47f..321423b 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev)
>      }
>  
>      if (pread(fd, &ctrl, sizeof(ctrl),
> -              vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) {
> +              vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) {
>          return -errno;
>      }
>  

This is certainly trivial, I'll grab it for the respin of yesterday's
pull request.  Thanks,

Alex