[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the
|
From: |
Ashley Jonathan |
|
Subject: |
Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed |
|
Date: |
Mon, 11 Jan 2016 09:29:55 +0000 |
Apologies; I overlooked that detail:
Signed-off-by: Ashley Jonathan <address@hidden>
Regards,
--
Jon Ashley
-----Original Message-----
From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
Sent: 11 January 2016 09:16
To: Ashley Jonathan; address@hidden
Cc: address@hidden
Subject: Re: [PATCH] Keep pty slave file descriptor open until the master is
closed
On 11/12/2015 12:29, Ashley Jonathan wrote:
> I have experienced a minor difficulty using QEMU with the "-serial
> pty" option:
>
> If a process opens the slave pts device, writes data to it, then
> immediately closes it, the data doesn't reliably get delivered to the
> emulated serial port. This seems to be because a read of the master
> pty device returns EIO on Linux if no process has the pts device open,
> even when data is waiting "in the pipe".
>
> A fix seems to be for QEMU to keep the pts file descriptor open until
> the pty is closed, as per the below patch.
You need to include a "Signed-off-by: Ashley Jonathan <address@hidden>"
line in the commit message, meaning that you have read and understood the
"Developer Certificate of Origin":
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
Just reply to this message with the above line.
Paolo