[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PULL 17/24] qom/object: fix 2 comment typos

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PULL 17/24] qom/object: fix 2 comment typos
Date: Thu, 12 Nov 2015 21:33:17 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0

12.11.2015 20:53, Andreas Färber wrote:
> Am 06.11.2015 um 13:43 schrieb Michael Tokarev:
>> From: Cao jin <address@hidden>
>> Also change the misleading definition of macro OBJECT_CLASS_CHECK
>> Signed-off-by: Cao jin <address@hidden>
>> Signed-off-by: Michael Tokarev <address@hidden>
> Michael, please *STOP* queuing QOM patches! You merged the unfixed

I think I do more harm to the project than good, these days.

> version now - it's supposed to have just "qom:", and the parenthesis and
> full stop are missing, too, that I had on qom-next before it disappeared
> with today's rebase...
> And why was I not CC'ed on this submission as include/qom/object.h
> maintainer? You did not reply to the patch either, where I did.

I didn't reply there because I wanted to remove the patch, exactly
because you replied to the thread.  It looks like I forgot to remove
it from the -trivial tree.

Now, in the original thread, you said you only tweaked the commit
(subject) message.  Is it really that bad in the original submission?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]