[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 01/36] qapi: add comment block before ChardevD
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [PATCH 01/36] qapi: add comment block before ChardevDummy |
Date: |
Fri, 25 Sep 2015 09:03:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> This is mainly to please the doc generation that requires comment block
> before the declaration.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qapi-schema.json | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
Could be taken through trivial branch now without waiting for pending
qapi patches, hence I've added a cc.
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 516c95b..3e2e53d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3042,13 +3042,17 @@
> { 'struct': 'ChardevRingbuf', 'data': { '*size' : 'int' } }
>
> ##
> +# @ChardevDummy
> +##
> +{ 'struct': 'ChardevDummy', 'data': { } }
I might eventually reach the point where we could use:
{ 'union': 'ChardevBackend', 'data': { ...
'pty': {},
... } }
instead of needing 'pty': 'ChardevDummy'. But my current pending series
doesn't get us quite there yet, so it would be a separate cleanup anyways.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [PATCH 01/36] qapi: add comment block before ChardevDummy,
Eric Blake <=