[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] trivial: remove trailing newl
From: |
John Snow |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report |
Date: |
Mon, 24 Aug 2015 20:19:34 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/09/2015 06:26 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 29, 2015 at 04:56:26PM -0400, John Snow wrote:
>> Minor cleanup.
>>
>> Signed-off-by: John Snow <address@hidden> --- hw/ide/ahci.c
>> | 2 +- hw/vfio/platform.c | 2 +- net/tap-linux.c | 4 ++-- 3
>> files changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Laszlo Ersek suggested a compile-time check (e.g. BUILD_BUG_ON()).
> Have you looked into this?
>
> Perhaps something along the lines of:
>
> BUILD_BUG_ON(__builtin_constant_p(fmt) && __builtin_strlen(fmt) > 0
> && fmt[__builtin_strlen(fmt) - 1] == '\n')
>
ping for 2.5; I don't think this ever made it in.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report,
John Snow <=