Re: [Qemu-trivial] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

[Alex Bennée]

Aurelien Jarno <address@hidden> writes:

> On 2015-08-03 10:14, Alex Bennée wrote:
>> This doesn't just dump CPU state on translation but on every block
>> entrance.
>> 
>> Signed-off-by: Alex Bennée <address@hidden>
>> Reviewed-by: Andreas Färber <address@hidden>
>> 
>> ---
>> v4
>>   - add r-b tag
>> ---
>>  qemu-log.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/qemu-log.c b/qemu-log.c
>> index 13f3813..be8405e 100644
>> --- a/qemu-log.c
>> +++ b/qemu-log.c
>> @@ -105,7 +105,7 @@ const QEMULogItem qemu_log_items[] = {
>>      { CPU_LOG_EXEC, "exec",
>>        "show trace before each executed TB (lots of logs)" },
>>      { CPU_LOG_TB_CPU, "cpu",
>> -      "show CPU state before block translation" },
>> +      "show CPU registers before each executed TB (lots of logs)" },
>>      { CPU_LOG_MMU, "mmu",
>>        "log MMU-related activities" },
>>      { CPU_LOG_PCALL, "pcall",
>
> In practice this is not true for linked TB. Should we also disable TB
> linking when this option is enabled?

Good question. I suspect yes because if you've gone to level of wanting
exec tracing you'll probably get confused by the chaining. Of course it
will run a lot slower then.


-- 
Alex Bennée